cloudposse / prometheus-to-cloudwatch

Utility for scraping Prometheus metrics from a Prometheus client endpoint and publishing them to CloudWatch
https://cloudposse.com/accelerate
Apache License 2.0
169 stars 37 forks source link

makes an additional_dimensions parameter #38

Open smaldon-bjss opened 4 years ago

smaldon-bjss commented 4 years ago

additional_dimension only accepts one dimension and I need multiple for my application, so I have copied the pattern in use for replace_dimensions and applied it to a new and discreet additional_dimensions.

I have maintained additional_dimension in the code for backwards compatibility although this could be removed. I thought it would be confusing to change the behaviour of additional_dimension although that approach would also be backwards compatible.

salkawari commented 4 years ago

hi, please implement this feature, i need to add a number of dimensions to get my grafana dashboard working better