cloudposse / terraform-aws-dms

Terraform modules for provisioning and managing AWS DMS resources
https://cloudposse.com/accelerate
Apache License 2.0
7 stars 7 forks source link

Add support for map_boolean_as_boolean #36

Closed finchr closed 1 month ago

finchr commented 1 month ago

what

Implemented postgres_settings for map_boolean_as_boolean as well as map_jsonb_as_clob and map_long_varchar_as.

why

map_boolean_as_boolean defaults to false and this is not what we want for our DMS.

references

closes #35

mergify[bot] commented 1 month ago

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

mergify[bot] commented 1 month ago

💥 This pull request now has conflicts. Could you fix it @finchr? 🙏

finchr commented 1 month ago

💥 This pull request now has conflicts. Could you fix it @finchr? 🙏

done.

finchr commented 1 month ago

@joe-niland I just pushed code with an object implementation and complete set of attributes. I also updated the readme.

johncblandii commented 1 month ago

/terratest

joe-niland commented 1 month ago

Thanks @finchr looks good. It seems the tests are failing due to engine_version = 3.4 - I'm not familiar with this service, but shall we try with 3.5? I'm aware this has nothing to do with your change, so I can try to look at fixing this separately when time.

cc: @johncblandii

goruha commented 1 month ago

/terratest

finchr commented 1 month ago

Thanks @finchr looks good. It seems the tests are failing due to engine_version = 3.4 - I'm not familiar with this service, but shall we try with 3.5? I'm aware this has nothing to do with your change, so I can try to look at fixing this separately when time.

cc: @johncblandii

@joe-niland I updated the engine_version to 3.5 and did another push

github-actions[bot] commented 1 month ago

These changes were released in v1.3.0.