Closed finchr closed 1 month ago
[!IMPORTANT]
Cloud Posse Engineering Team Review Required
This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.
To expedite this process, reach out to us on Slack in the
#pr-reviews
channel.
💥 This pull request now has conflicts. Could you fix it @finchr? 🙏
💥 This pull request now has conflicts. Could you fix it @finchr? 🙏
done.
@joe-niland I just pushed code with an object implementation and complete set of attributes. I also updated the readme.
/terratest
Thanks @finchr looks good.
It seems the tests are failing due to engine_version = 3.4
- I'm not familiar with this service, but shall we try with 3.5
?
I'm aware this has nothing to do with your change, so I can try to look at fixing this separately when time.
cc: @johncblandii
/terratest
Thanks @finchr looks good. It seems the tests are failing due to
engine_version = 3.4
- I'm not familiar with this service, but shall we try with3.5
? I'm aware this has nothing to do with your change, so I can try to look at fixing this separately when time.cc: @johncblandii
@joe-niland I updated the engine_version to 3.5 and did another push
These changes were released in v1.3.0.
what
Implemented postgres_settings for map_boolean_as_boolean as well as map_jsonb_as_clob and map_long_varchar_as.
why
map_boolean_as_boolean defaults to false and this is not what we want for our DMS.
references
closes #35