cloudposse / terraform-aws-elasticsearch

Terraform module to provision an Elasticsearch cluster with built-in integrations with Kibana and Logstash.
https://cloudposse.com/accelerate
Apache License 2.0
216 stars 231 forks source link

Add variable to control creation of aws_iam_role.elasticsearch_user resource #160

Closed mohamed-essam closed 1 year ago

mohamed-essam commented 1 year ago

Describe the Feature

aws_iam_role.elasticsearch_user resource is created when any iam_role_arns or iam_authorizing_role_arns are defined

Expected Behavior

Resource is not needed for cluster creation and is an extra usability resource that's not needed for everyone and should not be automatically added

Use Case

Our current setup adds permissions to the role attached to EC2 directly, and does not support assuming another role, thus this role will be unused and will trigger an internal control on unused IAM roles

Describe Ideal Solution

Add var.create_elasticsearch_user_role variable and default to true so it wouldn't break older versions

Alternatives Considered

No response

Additional Context

No response