search

cloudposse / terraform-aws-rds

Terraform module to provision AWS RDS instances
https://cloudposse.com/accelerate
Apache License 2.0
153 stars 180 forks source link

'engine_version' is required when 'snapshot_identifier' is specified #154

Open ragumix opened 1 year ago

ragumix commented 1 year ago

Describe the Bug

Looks like there is a mistake in the module regarding the engine_version parameter. When snapshot_identifier parameter specified, it needs to specify engine_version parameter. If engine_version parameter is not specified, the following suggestion will be showed:

var.engine_version Database engine version, depends on engine type. Required unless a snapshot_identifier or replicate_source_db is provided.

Enter a value:

According to the official documentation (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#engine_version), there is no mentioning that it doesn't need to specify engine_version when you specified snapshot_identifier.

Expected Behavior

Fix description for engine_version parameter. Please delete this sentence for engine_version:

Required unless a snapshot_identifier or replicate_source_db is provided.

Steps to Reproduce

Try to create RDS from snapshot without specifying engine_version parameter.

Screenshots

No response

Environment

No response

Additional Context

No response