feat: Add tags for Glue Databases

cloudquery / cq-provider-aws

CloudQuery Provider for AWS

https://cloudquery.io

Mozilla Public License 2.0

29 stars 40 forks source link

Closed travwarren closed 2 years ago

travwarren commented 2 years ago

Adds tags for Glue databases

Use the following steps to ensure your PR is ready to be reviewed

[x] Read the contribution guidelines 🧑‍🎓
[x] Run go fmt to format your code 🖊
[x] Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
[x] Update or add tests. Learn more about testing here 🧪
[x] Update the docs by running go run ./docs/docs.go and committing the changes 📃
[ ] Ensure the status checks below are successful ✅

erezrokah commented 2 years ago

Hi @travwarren and thank you for the PR 🎉 You've caught us in a middle of a migration to a monorepo, and the code for the AWS provider is now here.

I've recreated your PR (using your commits) in https://github.com/cloudquery/cloudquery/pull/1326 so we can continue the work there. You can also recreate it yourself if you'd like

erezrokah commented 2 years ago

Closing in favor of https://github.com/cloudquery/cloudquery/pull/1326, we do any follow up work there. Thanks for the contribution @travwarren 🚀