executing statement followed by comment fails, which seems a bug

cloudspannerecosystem / spanner-cli

Interactive command line tool for Cloud Spanner

Apache License 2.0

230 stars 28 forks source link

Closed Jumpaku closed 1 year ago

Jumpaku commented 1 year ago

Maybe, I found a regression related to processing a comment after a statement.

When the version is v0.9.16, the following command outputs 1.

echo 'select 1; /* comment */' > stmt.sql
spanner-cli -p $PROJECT -i $INSTANCE -d $DATABASE -f stmt.sql

However, when the version is v0.9.17 the above command fails with ERROR: invalid statement.

Does the behavior with v0.9.17 need correction?

apstndb commented 1 year ago

It seems a bug. Let me investigate.

yfuruyama commented 1 year ago

Thanks @Jumpaku for the report, and thanks @apstndb for the quick fix.

Thanks!