cloudspannerecosystem / spanner-dump

Command line tool for exporting a Cloud Spanner database in text format
Apache License 2.0
39 stars 13 forks source link

Adding a options flag to allow you to not dump any data. #11

Closed bgood closed 3 years ago

bgood commented 3 years ago

By using the no-data flag you can easily dump just the DDL.

yfuruyama commented 3 years ago

Thank you for filing a pull request!

I'm wondering what is the use case of this option because dumping DDL is officially supported by gcloud spanner databases ddl describe. Probably this is for users who are familiar with mysqldump --no-data command?

bgood commented 3 years ago

I initially implemented as a convenience thing for users already using the spanner-dump tool, so users didn't have to flip between glcoud and spanner-dump.

Your point about about mysqldump --no-data is a good one, but not my initial motivation.

yfuruyama commented 3 years ago

That makes sense. I will merge this PR.