search

cloudspannerecosystem / spanner-dump

Command line tool for exporting a Cloud Spanner database in text format
Apache License 2.0
39 stars 13 forks source link

Test is flaky or the build is broken #8

Closed rakyll closed 4 years ago

rakyll commented 4 years ago

Looks like it might be a timezone issue. See the log below:

 go test ./...
--- FAIL: TestDecodeColumn (0.00s)
    --- FAIL: TestDecodeColumn/date (0.00s)
        decoder_test.go:282: DecodeColumn(2018-01-22) = "DATE \"2018-01-22\"", want = "DATE \"2018-01-23\""
    --- FAIL: TestDecodeColumn/array_date (0.00s)
        decoder_test.go:282: DecodeColumn([2018-01-22 2018-01-23]) = "[DATE \"2018-01-22\", DATE \"2018-01-23\"]", want = "[DATE \"2018-01-23\", DATE \"2018-01-24\"]"
FAIL
FAIL    github.com/cloudspannerecosystem/spanner-dump   0.191s
FAIL
yfuruyama commented 4 years ago

Thank you for catching this issue. Actually this is timezone issue.

Fixed: https://github.com/cloudspannerecosystem/spanner-dump/pull/10