Fails if invalid custom types are specified

cloudspannerecosystem / yo

yo is a command-line tool to generate Go code for Google Cloud Spanner.

MIT License

312 stars 52 forks source link

Fails if invalid custom types are specified #84

Closed shuheiktgw closed 2 years ago

shuheiktgw commented 2 years ago

Please read the contribution guidelines and the CLA carefully before submitting your pull request.

https://cla.developers.google.com/

Currently, the yo command succeeds even if non-existing custom type tables or columns are specified. This behavior makes it hard for users to notice misconfiguration in their custom types. It would be great if yo would validate their existence so I implemented the logic. Thank you for your review!

shuheiktgw commented 2 years ago

@kazegusuri Updated it! Would you review the PR again? 🙏