search

cloudspokes / GLIB-ChromeExt

Github Launch Issue Button for Topcoder.com
http://www.topcoder.com
2 stars 30 forks source link

Need guidance before Pull Request #39

Closed thkang2 closed 8 years ago

thkang2 commented 8 years ago

Hi, as the Appeals Response phase has ended I understand that I'll be sending a pull request, I think some clarifications are needed before actually sending them.

You can see the latest version at https://github.com/thkang2/GLIB-ChromeExt/tree/updateTopcoderAuth

  1. The challenge creation function - they're disabled. Before my change the button started a chain of promises, which did (simplified) 1)Authenticate - 2)Submit challenge to topcoder server - 3)post comments to github/jira/gitlab server. Currently the button just alert you a json web token. No challenge posting. Should I leave this or change them?
  2. Please download the extension and go to the options page. It has more fields that I added. I just made them so reviewers can see it but really don't think they are necessary as they should be internals and not be configurable.
  3. Should I include the mock oauth server?
  4. It seems chrome extension doesn't have any javascript import/require system, instead it relies on some kind of script injection by creating a background.html on the fly and insert js files via <script src=".."> in the order of them in manifest.json. This breaks code linting as there will be undeclared globals. Any solution on this?
gbockus commented 8 years ago
  1. Change it back to the original flow, but using your JWT token auth code. .
  2. Also revert the options to the original state.
  3. Sure leave it in. You might add a README to that directory with instructions on how to use it.
  4. Update the linting options to specifically include exceptions for the globals required.

Thanks

thkang2 commented 8 years ago

@gbockus Please check https://github.com/cloudspokes/GLIB-ChromeExt/pull/40

Thanks!