cloudtrends / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
1 stars 1 forks source link

Enhancement for exposing popup features #135

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
There is a WebKit::WebWindowFeatures that gets passed to CEF when a new popup 
is requested. This can have certain request parameters, which might be useful 
to whoever is embedding CEF, so I am exposing these when a popup is requested.

There is a bug in the implicit constructor of a WebKit::WebWindowFeature from 
the WebCore::WindowFeatures. I've created a bug report for that located here, 
and the patch for that fix. Hopefully we can track the progress of that as 
well. 

WebKit bug report: https://bugs.webkit.org/show_bug.cgi?id=48035

Original issue reported on code.google.com by udam.sa...@gmail.com on 21 Oct 2010 at 1:52

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by magreenb...@gmail.com on 21 Oct 2010 at 8:52

GoogleCodeExporter commented 9 years ago
Looks like the webkit patch has gone through in webkits revision 71391. Not 
sure when that'll get into chromium though.

Original comment by udam.sa...@gmail.com on 5 Nov 2010 at 8:52

GoogleCodeExporter commented 9 years ago
Looks like that WebKit revision was rolled in Chromium revision 65192. You can 
find this kind of information in the src/DEPS revision log:
http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?view=log

Original comment by magreenb...@gmail.com on 6 Nov 2010 at 12:20

GoogleCodeExporter commented 9 years ago
Committed with style changes as revision 139. Please follow the style guide at 
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml

Original comment by magreenb...@gmail.com on 16 Nov 2010 at 4:48

GoogleCodeExporter commented 9 years ago
Issue 93 has been merged into this issue.

Original comment by magreenb...@gmail.com on 16 Nov 2010 at 5:09