search

clvrobj / Pinboard-Plus

Pinboard.in Chrome extension, not official.
https://chrome.google.com/webstore/detail/mphdppdgoagghpmmhodmfajjlloijnbd
Other
144 stars 36 forks source link

"read later" option gets set even if checkbox is not marked #19

Closed sheijk closed 10 years ago

sheijk commented 10 years ago

When adding a bookmark the "read later" checkbox is off by default. Yet the bookmark in Pinboard will be marked as "read later". If I mark the checkbox once and unmark it again "read later" will not be set in Pinboard.

  1. Go to https://github.com/clvrobj/Pinboard-Plus/blob/master/README.md
  2. click the Pinboard Plus menu bar icon so the popup window appears
  3. add any tags but leave everything else unchanged
  4. hit enter key to confirm

Expected: bookmark is added but "read later" flag is not set Found: "read later" flag is set ("mark as read" appears in the bookmark list on Pinboard)

If in step 4 the mouse is used to click the "Submit" button instead the bookmark is saved as expected. Also when marking the "read later" checkbox and the unmarking it again (using the mouse) between steps 3 and 4 the problem does not happen anymore.

geetarista commented 10 years ago

Been seeing the same thing. I also don't remember notes auto-filling either.

geetarista commented 10 years ago

Everything works fine for me after the update. Thanks!

sheijk commented 10 years ago

Fine for me, too. Thanks for the fix :)

clvrobj commented 10 years ago

@sheijk @geetarista Great, issue closed, thanks.