search

clvrobj / Pinboard-Plus

Pinboard.in Chrome extension, not official.
https://chrome.google.com/webstore/detail/mphdppdgoagghpmmhodmfajjlloijnbd
Other
144 stars 36 forks source link

Make <blockquote> on selected text optional #21

Closed spl closed 10 years ago

spl commented 10 years ago

I don't want <blockquote> around my Notes text, so I changed it to be an option. This works fine for me, but it has a few issues that could be improved.

  1. The new text on the options page shows up as shifted to the right for some reason, and I'm not sure why. It seems like the third <p> in the <section> is always this way. Maybe you know why? pinboard-options
  2. This changes the default for using <blockquote>s to false, which would probably surprise users. I think it's logically better to present the option where checked means “use <blockquote>s” instead of “don't use.” However, It would probably be a good idea to set the default to true. I wasn't sure of the appropriate way to do that.
clvrobj commented 10 years ago

I like this idea, thx, I'll try to fix the style of options page.

spl commented 10 years ago

Thanks!

clvrobj commented 10 years ago

I agree with you, using <blockquote> to false by default will surprise users, I think keep it is better, so I just make a change to set it to true by default in options page, but I use nouseblockquote to store the value in the code. refer to https://github.com/clvrobj/Pinboard-Plus/commit/c41b865f7a9241346f7f508843622a7b68f7a372.

spl commented 10 years ago

No problem. Thanks for the pointer. As far as grammatical usage goes, I would suggest (1) noblockquote or (the more verbose) dontuseblockquote rather than nouseblockquote and (2) the simpler useBlockquote over isUseBlockquote, which is a bit confusing.

clvrobj commented 10 years ago

That's helpful! :+1: