search

clvrobj / Pinboard-Plus

Pinboard.in Chrome extension, not official.
https://chrome.google.com/webstore/detail/mphdppdgoagghpmmhodmfajjlloijnbd
Other
144 stars 36 forks source link

Use canonical URL instead of actual URL #33

Open Glutnix opened 8 years ago

Glutnix commented 8 years ago

For example:

https://hackernoon.com/10-questions-to-ask-every-startup-founder-c64e1b6deb5b#.r23aoase0

has in its source a canonical link:

<link rel="canonical" href="https://hackernoon.com/10-questions-to-ask-every-startup-founder-c64e1b6deb5b">

Note the missing hash fragment. If Pinboard-Plus could use this, when available, that would be the best.

Assuming @clvrobj would like this feature, I'd like to try my hand at it, and will submit a PR on this. Please, let me know!

clvrobj commented 8 years ago

Hi @Glutnix, Happy to see this good idea. But I think if we change to submit the URL using the canonical link, we have to also change the logic of checking of whether the URL has been bookmarked already. I mean we can not change only on the submitting side, otherwise there is the side effect: imagine that after the link submitted using the canonical URL, then the extension can not tell the current page is bookmarked already as the URL being submitted is not same as the URL displayed in the browser's search bar which is with the hash fragment. I am worried about user might be confused. If you can change the both side, then it will be fine. Thanks.