search

clvrobj / Pinboard-Plus

Pinboard.in Chrome extension, not official.
https://chrome.google.com/webstore/detail/mphdppdgoagghpmmhodmfajjlloijnbd
Other
144 stars 36 forks source link

Add option to auto-enable 'private' in Incognito Mode. #34

Closed the-kenny closed 7 years ago

the-kenny commented 8 years ago

Adds a feature to auto-check the 'private' checkbox when PinboardPlus is used in Incognito Mode.

the-kenny commented 8 years ago

If you're interested in it I want to extend this PR with another new setting that disables pinging the Pinboard API when running in Incognito Mode.

clvrobj commented 7 years ago

Thanks for the idea of auto-check the 'private' checkbox. For disabling pinging the Pinboard API when running in Incognito Mode, I am worried about user might no aware that the extension are stop pinging the API in the mode and might think it is bug. Let me merge this first.

the-kenny commented 7 years ago

Good thinking, it could really confuse users. Maybe we can show a small icon + tooltip if it's disabled in incognito mode?

Am 04.12.2016 07:35 schrieb "Chi Zhang" notifications@github.com:

Thanks for the idea of auto-check the 'private' checkbox. For disabling pinging the Pinboard API when running in Incognito Mode, I am worried about user might no aware that the extension are stop pinging the API in the mode and might think it is bug. Let me merge this first.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/clvrobj/Pinboard-Plus/pull/34#issuecomment-264687472, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB5v53eer_ZMoe5knyeVXfBCtQ6qkMlks5rEl8ggaJpZM4K-5Jv .

clvrobj commented 7 years ago

Yeah, I think badge + tooltip might be a solution.