search

clvrobj / Pinboard-Plus

Pinboard.in Chrome extension, not official.
https://chrome.google.com/webstore/detail/mphdppdgoagghpmmhodmfajjlloijnbd
Other
144 stars 36 forks source link

Case sensitive auto completion for tags #41

Closed moon6pence closed 5 years ago

moon6pence commented 6 years ago

Hello, thanks for good app for pinboard.

I have been using tags with pascal style, like this: Play Recipes Apps However, auto completion of tags suggests me only lower case of tags and it's even harder to just type case sensitive tag. It automatically changes tags to lower case.

Is it possible to use tag not to be forced as lower case?

jorge0136 commented 5 years ago

I believe this is being caused by a handful of toLowerCase() calls. Namely in app/scripts/keywords_suggestions.js and app/scripts/popup.js.

Is there a reason to enforce lowercase @clvrobj ? If it's a preference for some, can we toggle this behaviour with an option, similar to how Private checkbox checked by default works?

clvrobj commented 5 years ago

Thanks, guys. The lowercase is just for matching the input tag. I got an idea to improve it, will give it a try.

clvrobj commented 5 years ago

Fixed by #50 and new package released today.