search

clvrobj / Pinboard-Plus

Pinboard.in Chrome extension, not official.
https://chrome.google.com/webstore/detail/mphdppdgoagghpmmhodmfajjlloijnbd
Other
144 stars 36 forks source link

Tag Suggestions Always the Same #43

Closed cmesoar closed 6 years ago

cmesoar commented 6 years ago

Great extension - thanks! However, it seems that every pin I make regardless of the website I am on always suggest the same set of tags! And the tags are seemingly totally unrelated to the page. This is what it suggests: ifttt twitter facebook WSH objective-c twitterlink 1960s @codepo8 Aiviq art

When I go to pinboard, the links are saved with the tags I've entered just fine, so it appears to be functioning correctly against the pinboard api

kriswilk commented 6 years ago

I have noticed these odd suggestions popping up a lot, too. This can't be right...

clvrobj commented 6 years ago

Thanks for the reporting the issue.

The tags displayed in the extension are recommended tags by Pinboard base on the current URL. Those tags you mentioned I believe are the default tags returned by the Pinboard API, which are displayed when the URL is new or somehow, not enough info to recommend tags for it.

cmesoar commented 6 years ago

Thanks for the response, I understand what you mean. Wouldn't it be possible, and perhaps quite usable, in that case, to return the metatags from the html on the page? Those would likely be at least related to the content on the page if the designer is doing anything at all correctly!! :)

ventz commented 6 years ago

It would be great if the "keywords" meta tag could be used (maybe combined with some popularity?) from the page itself.

I've actually noticed that currently the tags are in one of two extremes: either incredibly accurate (for tech stuff especially, ex: javascript/nodejs, etc), or incredibly inaccurate :)

ventz commented 6 years ago

Created a PR (https://github.com/clvrobj/Pinboard-Plus/pull/47) that will pull local meta keywords when available, in order to provide better/more accurate suggested keywords.

clvrobj commented 6 years ago

Thanks for the contribution from @ventz ! The PR #47 has been merged and deployed to the Chrome web store.