search

clyveycui / pe

0 stars 0 forks source link

DG incorrect diagram #17

Open clyveycui opened 2 years ago

clyveycui commented 2 years ago

image.png

nus-pe-bot commented 2 years ago

Team's Response

This is the default AB3 diagram for delete and our delete implementation has not changed on the high level.

Nothing needs to be changed from the default diagram.

If you were wondering about the lifeline after the delete market X, we have provided a markdown block to explain it.

image.png

Given that there are no errors in the single sequence diagram that you have sent us, we will be rejecting this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi, sorry for not clarifying due to the time constraints of the PE. What I meant is that if you were to look at the return arrow for the execute() method invocation of the d:DeleteCommand, it says that a result is returned. But that result is not specified inside uml diagram anywhere. I assume that it actually refers to the :CommandResult object, which isn't assigned any object name.

I understand that it is the default deletion diagram of AB3, but inherited bugs are still considered bugs.

Given that it is somewhat reasonable to infer that the result refers to the :CommandResult object, I agree that it can be considered a cosmetic issue.

Best regards!

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]