search

cmackay / google-analytics-plugin

Cordova Google Analytics Plugin for Android & iOS
Apache License 2.0
89 stars 43 forks source link

use strict not working well with cordova? #35

Closed boynet closed 9 years ago

boynet commented 9 years ago

for example if I send number into sendEvent label than it throws(we should call .toString but that for another issue)

TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them

inside cordova checkArgs function

cmackay commented 9 years ago

Thanks for your message. You might want to submit this issue to the Cordova repository containing checkArgs. Also if you have a proposed solution for handling this within the plugin, you are welcome to submit a pull request for review.

Thanks,

-Craig

boynet commented 9 years ago

why not to remove use strict from the production code? only use it on dev

cmackay commented 9 years ago

I will remove 'use strict' and push out a new release

cmackay commented 9 years ago

A new version of the plugin has been published to the cordova repository with the change.

http://plugins.cordova.io/#/package/com.cmackay.plugins.googleanalytics

boynet commented 9 years ago

thanks :+1: