search

cmackay / google-analytics-plugin

Cordova Google Analytics Plugin for Android & iOS
Apache License 2.0
89 stars 43 forks source link

Remove dependency and use cordova framework tag #44

Closed petarov closed 9 years ago

petarov commented 9 years ago

As described at https://github.com/MobileChromeApps/google-play-services, the google play services plugin is deprecated. Plugins should now use the framework tags instead.

This also fixes a build error, i.e., Error: more than one library with package name 'com.google.android.gms' when using this plugin and the admob cordova plugin. Both use google play services, but (AFAIS) different versions.

cmackay commented 9 years ago

Thanks @petarov, I appreciate you submitting the pull request. I am going to test out the change and then publish a new release. It should be available later today.

Thanks,

-Craig

cmackay commented 9 years ago

I have published the updated version 0.1.16 to npm with the changes you made. I guess the old cordova repository is read only now so I can't publish an update to that.

Thanks @petarov !

petarov commented 9 years ago

Awesome! Thank you :beer: