protoc command not generating correct package imports

neocortical commented 7 years ago

I'm attempting to generate the pb.go files for TF and TF Serving and I ran across this repo. I am having an issue with the protoc output that I see here as well.

Specifically, import statements for sibling packages are not getting generated correctly. In vendor/tensorflow/core/protobuf/meta_graph.pb.go, for example, the following imports appear:

import tensorflow10 "tensorflow/core/framework"
import tensorflow7 "tensorflow/core/framework"
import tensorflow2 "tensorflow/core/framework"
import tensorflow3 "tensorflow/core/framework"

The correct code should be a single, fully qualified import statement for the framework package, e.g.

import "github.com/myaccount/myproject/tensorflow/core/framework"

I've tried various incarnations of protoc and --go_out without luck. Do you happen to have any insight?

Thanks!

denis-trofimov commented 5 years ago

@neocortical good point! I fell into the same trap :( Have any clues to fix it? @cmars

cmars commented 5 years ago

I did this as a one-off demo a while back and haven't been following developments in TF/protobufs to keep it current. My current interests are elsewhere.

I'd merge a PR if anyone has ideas though.

denis-trofimov commented 5 years ago

Ok NP. I have no solution yet.04.04.2019, 20:15, "Casey Marshall" notifications@github.com:I did this as a one-off demo a while back and haven't been following developments in TF/protobufs to keep it current. My current interests are elsewhere. I'd merge a PR if anyone has ideas though.

—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

-- Искренне Ваш,Денис "Я - сила и радость!" Трофимов.Блог http://denistrofimov.iblogger.org/

cmars / tfclient

protoc command not generating correct package imports #3