cmflannery / openrocketengine

openrocketengine is an opensource program used to iterate liquid engine design
MIT License
29 stars 10 forks source link

Dataset Generation #1

Open mphalen opened 7 years ago

mphalen commented 7 years ago

So there are a few options for generating propellant datasets:

A) We could scrape CEAWeb; but for each Mixture Ratio+exit pressure combination we'd need 60 plus data points (chamber pressure). So a full data set for one propellant would likely require 600+ data points, likely more.

CEAWeb has a bug where if you're defining P_Chamber/P_Exit you can only input one MR and one pressure ratio, meaning that only one data point can be pulled from a request to CEAWeb.

B) We could build a wrapper around CEA executables//use f2py to port CEA to python. This option is more feasible but possibly introduces bugs//errors into our code base. More importantly, it rather defeats the purpose of 'Open' in openrocketengine as we'd be interacting with a black box of sorts, likely with more utility than we'd need. This would make maintenance of the code base more complicated.

C) Either use or develop a computational chemistry solution that's lightweight and maintainable.

cmflannery commented 7 years ago

I'm leaning towards option B. Porting CEA to python using f2py. We should test the ported version of CEA to make sure we are getting the expected values.

codeflight1 commented 4 years ago

It looks like somebody has already done option B: https://github.com/sonofeft/RocketCEA