search

cms-PdmV / cmsPdmV

CERN CMS McM repository
4 stars 10 forks source link

Allow `generator contacts` to update the `dataset_name` attribute #1117

Closed ggonzr closed 8 months ago

ggonzr commented 8 months ago

Solves: #1116

  1. Allow the described role to modify the dataset name after the validation step.
sunilUIET commented 8 months ago

Thanks @ggonzr , can we add permission to edit "extension" and "process_string" as well? It helps to resolve dataset name conflicts.

ggonzr commented 8 months ago

Also, should we allow generator_conveners to modify them?

sunilUIET commented 8 months ago

Yes, we can do that

ggonzr commented 8 months ago

I have deployed this change into the development environment and prepared a test request [1]. @tvami please can you check it, modify its dataset_name and let us know if the update solves your requirement. If it is okay, @sunilUIET please can you approve the change to merge it. Thanks.

References: [1]. Test request: https://cms-pdmv-dev.web.cern.ch/mcm/requests?prepid=PPD-Run3Summer21wmLHEGS-00003&page=0&shown=127

tvami commented 8 months ago

hi @ggonzr looks good, thanks a lot! @sunilUIET please go ahead with the approval if you agree, thanks!