cms-l1-dpg / Phase2-L1Nano

NanoAOD ntupler for Phase-2 L1 Objects
Apache License 2.0
1 stars 5 forks source link

GTT Objects Prototype #9

Closed NJManganelli closed 6 months ago

NJManganelli commented 9 months ago

Rebase of https://github.com/cms-l1-dpg/Phase2-L1Nano/pulls:

This draft PR starts some GTT extensions/additions to the L1Nano format, from some exploration a few months ago and re-basing things now. As of now, this is incomplete, and could use person-power in GTT to extend it more usefully, and decide on what's worth putting in now/later (e.g. see Vertex nTracksIn/Out: can be uncommented now, but we don't fill these in the VertexWord yet)

A GTTValidation script is added which does a few nigh-trivial tests of Vertices and checks for what branches have been successfully added to the nano format (presumes you create a few-event file with the current master configuration and append the postfix indicated by the 'forig' file open near the top). When things are complete, it could be left as an example or deleted to clean things up.

artlbv commented 8 months ago

Hi @NJManganelli @BenjaminRS could you update me on the status of this? I would prefer if we could switch to nano asap, and now it's mostly the GTT objects that are missing. Given that they are not even included in the final menu for now, it would add some overhead to maintain the old ntupler just for them.

Can we have the tkJets, tkHT and tkMET in already now and add the TPs for your studies later? For the physical quantities I'd suggest we use hardcoded scales for now. I would like to do a menu ntuple vs nano validation in one go rather than incrementally first without and then with GTT.

artlbv commented 7 months ago

I tested this in 14x and it works fine, though I see the physical pt values of the sums are missing. Is there any way to resolve this, even with hardcoded scales e.g. l1tmetemu::kStepMET? I would then propose to merge this PR to help us in the validation.

this is what we did for the menu ntuples https://github.com/artlbv/cmssw/blob/from-CMSSW_12_5_2_patch1/L1Trigger/L1TNtuples/src/L1AnalysisPhaseIIStep1.cc#L617-L632