search

cms-sw / cmssw-config

CMSSW build configuration
4 stars 14 forks source link

Allow picking dependency types in 'scram b checkdeps' #103

Open kpedro88 opened 8 months ago

kpedro88 commented 8 months ago

git cms-checkdeps allows selecting different kinds of dependencies (header, python, or BuildFile). Right now, scram b checkdeps always checks all of them. Often, I find cases where I want to skip the python dependencies (the python dependency check is very broad and often gives false positives) but keep the others. Could arguments similar to the git version be provided for the scram version?

cmsbuild commented 8 months ago

cms-bot internal usage

cmsbuild commented 8 months ago

A new Issue was created by @kpedro88.

@rappoccio, @makortel, @sextonkennedy, @antoniovilela, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

smuzaffar commented 8 months ago

@kpedro88 , scram b passes most of the flags to make so scram b checkdeps <git-cms-checkdeps-opts> is not going to work. I can update the build rules so that one can do CHECKDEPS_OPTS='<opts> scram b checkdeps ( where scram then passes <opts> to git-cms-checkdeps . Will this be good enough ? Note that this type of change will only work in the release with updated build rules.

kpedro88 commented 8 months ago

Thanks @smuzaffar. Having it in new releases is better than not having it at all.

As an aside, it would be nice if these various options/environment variables/etc. were documented somewhere... e.g. scram b checkdeps doesn't show up anywhere in the scram help messages.

smuzaffar commented 8 months ago

@kpedro88 , checkdeps is a build rule and to get help on build rules you need to run scram b help in the cmssw dev area

kpedro88 commented 8 months ago

@smuzaffar now I recall that you've actually told me this before... but it only works in $CMSSW_BASE/src, not $CMSSW_BASE/src/X/Y (in the latter it just prints Doing "scram build" here will build every thing exist under this directory.). Maybe this could at least be clarified in the scram --help listing for the "help" build target?