search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.27k forks source link

Unit test `TestDQMOfflineConfigurationGotAll` failing due to extra sequences #45486

Open aandvalenzuela opened 1 month ago

aandvalenzuela commented 1 month ago

Hello,

Since CMSSW_14_1_X_2024-07-16-2300, unit test TestDQMOfflineConfigurationGotAll module (DQMOffline/Configuration) is failing with:

+ echo 'Sequences run by final DQMOfflineConfiguration: 9'
Sequences run by final DQMOfflineConfiguration: 9
+ '[' 9 -gt 0 ']'
+ echo 'Final DQMOfflineConfiguration should not run any sequences.'
Final DQMOfflineConfiguration should not run any sequences.
+ echo 'Please update parameters for TestDQMOfflineConfiguration unittest to run the extra sequences.'
Please update parameters for TestDQMOfflineConfiguration unittest to run the extra sequences.
+ exit 1

---> test TestDQMOfflineConfigurationGotAll had ERRORS

I do not see any recent merges that could have caused the appearance of these extra sequences, but I am tagging @mmusich since we had a similar issue three weeks ago (fixed in https://github.com/cms-sw/cmssw/pull/45287). Should we just increase the number of sequences as well?

Thanks, Andrea

cmsbuild commented 1 month ago

cms-bot internal usage

cmsbuild commented 1 month ago

A new Issue was created by @aandvalenzuela.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

mmusich commented 1 month ago

Should we just increase the number of sequences as well?

That will silence the failure. It's up to @cms-sw/dqm-l2 to clarify if the increase in the number of sequences is justified.

makortel commented 1 month ago

assign dqm

cmsbuild commented 1 month ago

New categories assigned: dqm

@rvenditti,@syuvivida,@tjavaid,@nothingface0,@antoniovagnerini you have been requested to review this Pull request/Issue and eventually sign? Thanks