cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Rename 2021 Wfs with 2022 #46649

Closed AdrianoDee closed 5 days ago

AdrianoDee commented 2 weeks ago

PR description:

Wfs running with 2022 conditions, setup and HLT (ok @relval2022 in this cycle is the fake one, but still) are still labelled as 2021 and I find it a bit odd. This PR proposes a small fix to have them labelled as "2022" wfs.

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Maybe useful to backport this down to 12_4_X that is the data taking release for 2022 (@cms-sw/orp-l2 ?). Not really strictly needed though.

AdrianoDee commented 2 weeks ago

type bug-fix

AdrianoDee commented 2 weeks ago

please test

cmsbuild commented 2 weeks ago

cms-bot internal usage

cmsbuild commented 2 weeks ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46649/42566

cmsbuild commented 2 weeks ago

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

@AdrianoDee, @Moanwar, @dickychant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 2 weeks ago

+1

Size: This PR adds an extra 32KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-07605a/42712/summary.html COMMIT: 7b3b6cd0d48bbb1b7632d050b7964858724c7446 CMSSW: CMSSW_14_2_X_2024-11-10-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46649/42712/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

AdrianoDee commented 2 weeks ago

+pdmv

cmsbuild commented 6 days ago

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

Moanwar commented 6 days ago

+Upgrade

cmsbuild commented 6 days ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 5 days ago

+1

mandrenguyen commented 5 days ago

+1

smuzaffar commented 4 days ago

@AdrianoDee , there are 8 relvals failing . Is this PR the cause of those failures?

AdrianoDee commented 4 days ago

@smuzaffar indeed it is. Opened the fix https://github.com/cms-sw/cmssw/pull/46793