Update the time resoultion of GEM Digitization

woohyeonHeo commented 2 weeks ago

PR description:

Update on GEM Digitization simulation

Changing the time resolution of GEMDigi to the more realistic value
https://indico.cern.ch/event/1471927/contributions/6197521/attachments/2959308/5210343/ME0_P2UG_Review.pdf : Page 26 and 27

PR validation:

The code format has applied with scram build code-format and tested with scram build code-checks
The branch has tested with the following command
```
runTheMatrix.py -w upgrade -l 3211.0
```

cmsbuild commented 2 weeks ago

cms-bot internal usage

cmsbuild commented 2 weeks ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46653/42574

cmsbuild commented 2 weeks ago

A new Pull Request was created by @gjdngus9809 for master.

It involves the following packages:

SimMuon/GEMDigitizer (upgrade, simulation)

@Moanwar, @civanch, @cmsbuild, @kpedro88, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @giovanni-mocellin, @jhgoh, @jshlee, @slomeo, @watson-ij this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

woohyeonHeo commented 2 weeks ago

@watson-ij

watson-ij commented 2 weeks ago

please test

cmsbuild commented 2 weeks ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a973b5/42718/summary.html COMMIT: 5e36a3fba04e380d26288a94f80522866ad4e2b0 CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46653/42718/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@perrotta cms-sw/cmssw#46644

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a973b5/42718/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a973b5/42718/git-merge-result

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 527 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3343588
DQMHistoTests: Total failures: 1395
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3342173
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

civanch commented 2 weeks ago

+1

Moanwar commented 2 weeks ago

+Upgrade

cmsbuild commented 2 weeks ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 2 weeks ago

+1

cms-sw / cmssw