cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.12k stars 4.38k forks source link

Fix trigger table for MUO@POG flavored nanoAOD #47139

Closed BlancoFS closed 2 weeks ago

BlancoFS commented 2 weeks ago

Some of the HLT filters introduced in the custom_muon_cff.py were outdated. The intention of this PR is to update them to match the 2024 HLT Menu v1.4 and introduce all the muon related paths. Moreover, the second table was wrong since the id was larger than Int16 format and, then, no object was stored. This is also fixed and the id is modified from 131313 to 1331.

This PR only affects the trigger bits stored in the custom MUO@POG nanoAOD.

P.d: Comments are added to help future developments and analyzers.

cmsbuild commented 2 weeks ago

cms-bot internal usage

cmsbuild commented 2 weeks ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47139/43366

cmsbuild commented 2 weeks ago

A new Pull Request was created by @BlancoFS for master.

It involves the following packages:

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks. @AnnikaStein, @gpetruc this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

hqucms commented 2 weeks ago

enable nano

hqucms commented 2 weeks ago

please test

cmsbuild commented 2 weeks ago

+1

Size: This PR adds an extra 32KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e7e74/43856/summary.html COMMIT: 54bc3c022e7fc227a90e7999287f9a54bfe2be7f CMSSW: CMSSW_15_0_X_2025-01-19-2300/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47139/43856/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e7e74/43856/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e7e74/43856/git-merge-result

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.114 3.114 0.000 ( +0.0% ) 6.29 6.26 +0.5% 2.543 2.549
2500.002 3.230 3.230 0.000 ( +0.0% ) 5.68 5.62 +1.1% 2.973 2.981
2500.003 3.171 3.171 0.000 ( +0.0% ) 5.92 5.83 +1.6% 2.951 2.953
2500.011 1.644 1.644 0.000 ( +0.0% ) 10.06 9.90 +1.6% 2.623 2.616
2500.012 2.184 2.184 0.000 ( +0.0% ) 5.91 5.85 +1.1% 2.816 2.824
2500.013 2.000 2.000 0.000 ( +0.0% ) 8.28 8.17 +1.4% 2.723 2.723
2500.021 0.022 0.022 0.000 ( +0.0% ) 2.06 2.05 +0.5% 2.603 2.596
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.98 1.97 +0.3% 2.593 2.588
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.90 1.86 +1.7% 2.460 2.459
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.53 1.54 -0.4% 2.692 2.697
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.77 1.74 +1.7% 2.643 2.649
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.78 1.80 -0.8% 2.622 2.616
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.71 1.71 +0.1% 2.698 2.702
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.69 1.69 +0.2% 2.680 2.674
2500.101 2.844 2.844 0.000 ( +0.0% ) 16.35 16.12 +1.4% 2.624 2.629
2500.111 1.463 1.463 0.000 ( +0.0% ) 31.16 30.38 +2.6% 2.317 2.320
2500.112 1.883 1.883 0.000 ( +0.0% ) 25.27 24.82 +1.8% 2.395 2.392
2500.131 0.750 0.750 0.000 ( +0.0% ) 37.04 36.64 +1.1% 1.502 1.466
2500.201 2.674 2.674 0.000 ( +0.0% ) 13.58 13.34 +1.7% 2.203 2.198
2500.211 1.806 1.806 0.000 ( +0.0% ) 26.87 26.21 +2.5% 2.405 2.402
2500.212 2.203 2.203 0.000 ( +0.0% ) 22.11 21.83 +1.3% 2.484 2.482
2500.221 2.038 2.038 0.000 ( +0.0% ) 14.14 14.18 -0.3% 2.114 2.111
2500.222 3.479 3.479 0.000 ( +0.0% ) 12.85 12.90 -0.4% 2.208 2.212
2500.223 9.444 9.444 0.000 ( +0.0% ) 4.17 4.17 -0.1% 2.290 2.233
2500.224 6.304 6.304 0.000 ( +0.0% ) 1.40 1.38 +1.7% 2.271 2.216
2500.225 6.350 6.350 0.000 ( +0.0% ) 1.30 1.28 +1.2% 2.449 2.417
2500.226 3.172 3.172 0.000 ( +0.0% ) 13.51 13.49 +0.1% 2.203 2.151
2500.227 1.442 1.442 0.000 ( +0.0% ) 23.80 23.44 +1.5% 1.448 1.403
2500.228 3.957 3.957 0.000 ( +0.0% ) 9.04 9.00 +0.5% 2.303 2.308
2500.231 1.457 1.456 0.002 ( +0.1% ) 22.39 21.89 +2.3% 2.282 2.285
2500.232 2.462 2.462 0.000 ( +0.0% ) 20.91 20.63 +1.4% 2.390 2.392
2500.233 4.954 4.954 0.000 ( +0.0% ) 6.18 6.00 +2.9% 2.456 2.458
2500.234 3.842 3.842 0.000 ( +0.0% ) 1.78 1.75 +1.6% 2.171 2.430
2500.235 3.873 3.873 0.000 ( +0.0% ) 1.67 1.64 +1.8% 2.368 2.629
2500.236 2.252 2.252 0.000 ( +0.0% ) 21.67 21.34 +1.5% 2.386 2.384
2500.237 1.018 1.018 0.000 ( +0.0% ) 34.95 34.50 +1.3% 1.453 1.457
2500.238 2.444 2.444 0.000 ( +0.0% ) 17.19 17.06 +0.8% 2.464 2.475
2500.241 9.404 9.404 0.000 ( +0.0% ) 7.54 7.67 -1.7% 1.927 1.922
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.65 1.67 -1.3% 1.723 1.724
2500.243 2.712 2.712 0.000 ( +0.0% ) 15.82 15.81 +0.1% 1.061 1.055
2500.244 486.016 486.016 0.000 ( +0.0% ) 1.14 1.14 +0.2% 1.701 1.682
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.54 1.53 +0.7% 1.683 1.670
2500.901 1.819 1.819 0.000 ( +0.0% ) 46.40 45.11 +2.9% 1.446 1.444
2500.902 1.665 1.665 0.000 ( +0.0% ) 49.14 47.60 +3.2% 1.338 1.335
2500.911 14.345 14.345 0.000 ( +0.0% ) 7.76 8.26 -6.0% 1.088 1.085
2500.912 0.171 0.310 -0.139 ( -44.8% ) 3.16 2.92 +8.2% 0.842 0.846
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.61 2.64 -0.8% 0.848 0.850
hqucms commented 2 weeks ago

+1

cmsbuild commented 2 weeks ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 2 weeks ago

+1