cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.12k stars 4.38k forks source link

run more testing in `CalibTracker/SiStripCommon` unit tests #47142

Closed mmusich closed 2 weeks ago

mmusich commented 2 weeks ago

PR description:

Due to recent works ongoing to streamline / optimize strip local reconstruction, I think it's prudent to enable more testing of the calibration tree workflows.

PR validation:

scram b runtests runs fine in CMSSW_15_0_X_2025-01-19-2300

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cmsbuild commented 2 weeks ago

cms-bot internal usage

cmsbuild commented 2 weeks ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47142/43368

cmsbuild commented 2 weeks ago

A new Pull Request was created by @mmusich for master.

It involves the following packages:

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. @echabert, @gbenelli, @mmusich, @robervalwalsh, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich commented 2 weeks ago

@cmsbuild, please test

cmsbuild commented 2 weeks ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a851d/43863/summary.html COMMIT: f786615a177a23e3bf5d5faf0907c3277d949b1f CMSSW: CMSSW_15_0_X_2025-01-20-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47142/43863/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

perrotta commented 2 weeks ago

+alca

cmsbuild commented 2 weeks ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 2 weeks ago

+1