cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.12k stars 4.38k forks source link

MTD geometry: address static CLANG analyzer error in Geometry/MTDNumberingBuilder #47143

Closed fabiocos closed 2 weeks ago

fabiocos commented 2 weeks ago

PR description:

PR https://github.com/cms-sw/cmssw/pull/47115 brings back the MTD geometry to its status previous to the update of BTL DetId/numbering scheme. In this way the reordering of BTL modules, added to that PR to minimize the number of updates of references, is undone as well, leaving a function makempiToppi, used in preprocessor blocks for debugging, not defined.

While this has no impact in normal code operation, it introduces a static CLANG analyzer error. This PR fixes the problem, without activating the change of order.

PR validation:

Code compiles, runs, unit test for the package passes, scram b checker does not show any more the CLANG error reported by the IB.

cmsbuild commented 2 weeks ago

cms-bot internal usage

cmsbuild commented 2 weeks ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47143/43369

cmsbuild commented 2 weeks ago

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @bsunanda, @martinamalberti this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

fabiocos commented 2 weeks ago

please test

cmsbuild commented 2 weeks ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a19272/43862/summary.html COMMIT: 7231ac13dc55f6f8b5c33e6cc0a5c32db6fac91e CMSSW: CMSSW_15_0_X_2025-01-19-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47143/43862/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

fabiocos commented 2 weeks ago

type fix

fabiocos commented 2 weeks ago

type bugfix

bsunanda commented 2 weeks ago

+geometry

Moanwar commented 2 weeks ago

+Upgrade

cmsbuild commented 2 weeks ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 2 weeks ago

+1