cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.12k stars 4.38k forks source link

Fix `cfi` creation for conf db parsing #47156

Closed mmusich closed 2 weeks ago

mmusich commented 2 weeks ago

PR description:

@Martin-Grunewald reported an issue in the confDB parsing of CMSSW_15_0_0_pre2 concerning:

 -> hltBcJpsiTkAllConeTracksIter [ConcreteChargedCandidateProducer] CHANGED
       string particleType = "K+" [REMOVED]
  -> hltCscSegments [CSCSegmentProducer] CHANGED
       VPSet algo_psets [REMOVED]

this is due to https://github.com/cms-sw/cmssw/pull/47017 and https://github.com/cms-sw/cmssw/pull/47045 having the modules ConcreteChargedCandidateProducer and CSCSegmentProducer auto-generate cfi files with incomplete top level parameter configurations. This PR fixes the issue

PR validation:

Upon compilation I get the following python files available:

$ more ../cfipython/el9_amd64_gcc12/CommonTools/RecoAlgos/ConcreteChargedCandidateProducer.py
import FWCore.ParameterSet.Config as cms

def ConcreteChargedCandidateProducer(*args, **kwargs):
  mod = cms.EDProducer('ConcreteChargedCandidateProducer',
    src = cms.InputTag(''),
    particleType = cms.string('pi+'),
    mightGet = cms.optional.untracked.vstring
  )
  for a in args:
    mod.update_(a)
  mod.update_(kwargs)
  return mod

and

$ more ../cfipython/el9_amd64_gcc12/RecoLocalMuon/CSCSegment/CSCSegmentProducer.py                                                                                                   import FWCore.ParameterSet.Config as cms

def CSCSegmentProducer(*args, **kwargs):
  mod = cms.EDProducer('CSCSegmentProducer',
    inputObjects = cms.InputTag('csc2DRecHits'),
    algo_type = cms.int32(5),
    algo_psets = cms.VPSet(
    ),
    mightGet = cms.optional.untracked.vstring
  )
  for a in args:
    mod.update_(a)
  mod.update_(kwargs)
  return mod

which is fine for parsing purposes.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

mmusich commented 2 weeks ago

type bug-fix

cmsbuild commented 2 weeks ago

cms-bot internal usage

mmusich commented 2 weeks ago

urgent

cmsbuild commented 2 weeks ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47156/43386

cmsbuild commented 2 weeks ago

A new Pull Request was created by @mmusich for master.

It involves the following packages:

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @abbiendi, @ahinzmann, @bellan, @gkasieczka, @hatakeyamak, @jdolen, @jhgoh, @missirol, @ptcox, @rappoccio this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich commented 2 weeks ago

@cmsbuild, please test

cmsbuild commented 2 weeks ago

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7237bc/43892/summary.html COMMIT: 7da557d79b20ff0649ba4299d0646620ba8d14ea CMSSW: CMSSW_15_0_X_2025-01-21-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47156/43892/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

jfernan2 commented 2 weeks ago

+1

cmsbuild commented 2 weeks ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 2 weeks ago

+1