cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.12k stars 4.38k forks source link

Fix compilation of HGCalRecHitProducers.cc #47179

Closed iarspider closed 1 week ago

iarspider commented 2 weeks ago

PR description:

Title says it all. See build log link

PR validation:

Bot tests

iarspider commented 2 weeks ago

please test for CMSSW_15_0_DBG_X

cmsbuild commented 2 weeks ago

cms-bot internal usage

cmsbuild commented 2 weeks ago

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47179/43418

Code check has found code style and quality issues which could be resolved by applying following patch(s)

iarspider commented 2 weeks ago

please test for CMSSW_15_0_DBG_X

cmsbuild commented 2 weeks ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47179/43419

cmsbuild commented 2 weeks ago

A new Pull Request was created by @iarspider for master.

It involves the following packages:

@Moanwar, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @ReyerBand, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @lgray, @missirol, @pfs, @rchatter, @rovere, @salimcerci, @sameasy, @sethzenz, @thomreis, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 2 weeks ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0e068/43938/summary.html COMMIT: 552d131e7ed2962e65658adea87d6166ec6a900f CMSSW: CMSSW_15_0_DBG_X_2025-01-23-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47179/43938/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

pfs commented 2 weeks ago

thank you @iarspider somehow this went unnoticed when our PR got integrated last week

jfernan2 commented 2 weeks ago

+1

iarspider commented 1 week ago

@cms-sw/upgrade-l2 gentle ping

Moanwar commented 1 week ago

+Upgrade

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 1 week ago

+1