cmseaton42 / node-ethernet-ip

A Lightweight Ethernet/IP API written to interface with Rockwell ControlLogix/CompactLogix Controllers.
MIT License
265 stars 106 forks source link

Allow 1-character Tag Names #18

Closed patrickjmcd closed 6 years ago

patrickjmcd commented 6 years ago

Fix for cmseaton42/node-ethernet-ip#17

Allows 1-character tag names. These tag names are valid tag names as long as the 1 character is not a number.

Description, Motivation, and Context

fixes regex in src/tag/index.js and adds tests

How Has This Been Tested?

tests added to src/tag/tag.spec.js

Screenshots (if appropriate):

n/a

Types of changes

Checklist:

Related Issue

17

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 69


Totals Coverage Status
Change from base Build 67: 0.0%
Covered Lines: 415
Relevant Lines: 793

💛 - Coveralls