cmseaton42 / node-ethernet-ip

A Lightweight Ethernet/IP API written to interface with Rockwell ControlLogix/CompactLogix Controllers.
MIT License
265 stars 106 forks source link

Feature adds for controller scan #21

Open jhenson29 opened 6 years ago

jhenson29 commented 6 years ago

Sample of suggested updates for Controller scan

Description, Motivation, and Context

Adds ability to remove and query tags in the subscription group. Adds ability to set scan for read only Check elapsed time for scan and modifies wait time accordingly so update rate is close to set scan rate. Added scan min overhead percent to keep a minimum amount of wait time relative to the task time

How Has This Been Tested?

Minimal testing against a PLC

Screenshots (if appropriate):

Types of changes

Checklist:

Related Issue

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 73


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controller/index.js 15 20 75.0%
<!-- Total: 17 22 77.27% -->
Totals Coverage Status
Change from base Build 70: 1.0%
Covered Lines: 431
Relevant Lines: 810

💛 - Coveralls