warrior decap doesnt check for the hugged flagged - Githubissues

cmss13-devs / cmss13

Contains the code for CM-SS13

https://cm-ss13.com

GNU Affero General Public License v3.0

95 stars 527 forks source link

warrior decap doesnt check for the hugged flagged #6087

Open Red-byte3D opened 6 months ago

Red-byte3D commented 6 months ago

Testmerges

dnm

Round ID

dnm

Description of the bug

https://github.com/cmss13-devs/cmss13/pull/4979 this doesnt work as you can still start the decap and get the decap off before the hugger is finished

What's the difference with what should have happened?

not this

How do we reproduce this bug?

1.hug man

grab man
behead man ...

Issue Bingo

[X] Issue could be reproduced at least once
[X] Issue happened in a recent (less than 7 days ago) round
[X] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

vero5123 commented 5 months ago

it does though

Drulikar commented 5 months ago

So impregnation occurs after a random amount of time when a hugger attaches. What they're saying is that it doesn't recheck can_not_harm after the do_after. This is really niche though. See https://github.com/cmss13-devs/cmss13/blob/357e4fe2dd4fd58dedddd1f75040350fc792783c/code/modules/mob/living/carbon/xenomorph/castes/Warrior.dm#L192C5-L192C17