Open ksaito7 opened 6 years ago
There is a bunch of Set methods in SettingsManager. I don't know how they interact with transactions though.
Set methods are just update methods for existed setting value using setting_id
. These can not create new settings actually.
What new settings do you wish to add (after the system has booted)?
I wanted users to be able to add original variables through SET command in psql or config files. But I found that Postgres can't set the original variables. I misunderstood that. Delete its line.
Can’t add new settings after Peloton booting. So we can’t implement SET command.So I propose setting refactoring for SettingManager and SettingsCatalog. Basically, I think setting user should control all functions through SettingManager, not static like other manager. Refactor points are below:
Add setting)TransactionContext
is passed through the function argument.