cmu-delphi / epiprocess

Tools for basic signal processing in epidemiology
https://cmu-delphi.github.io/epiprocess/
Other
13 stars 9 forks source link

Debug warnings and messages in outliers vignette #537

Open brookslogan opened 16 hours ago

brookslogan commented 16 hours ago

Outlier detection vignette chunk

x <- x %>%
  group_by(geo_value) %>%
  mutate(
    outlier_info = detect_outlr(
      x = time_value,
      y = cases,
      methods = detection_methods,
      combiner = "median"
    )
  ) %>%
  ungroup() %>%
  unnest(outlier_info)

yields

## Adding missing grouping variables: `geo_value`
## Adding missing grouping variables: `geo_value`
## Adding missing grouping variables: `geo_value`
## Adding missing grouping variables: `rm_geo_value`
## Adding missing grouping variables: `rm_geo_value`
## Adding missing grouping variables: `rm_geo_value`
## Adding missing grouping variables: `geo_value`
## Adding missing grouping variables: `geo_value`
## Adding missing grouping variables: `geo_value`
## Adding missing grouping variables: `rm_geo_value`
## Adding missing grouping variables: `rm_geo_value`
## Adding missing grouping variables: `rm_geo_value`

Why? Is this indicative of a bug, or are we just missing some tweak to avoid this spam?

brookslogan commented 16 hours ago

There's also later (in multiple places)

## Warning in max(ids, na.rm = TRUE): no non-missing arguments to max; returning
## -Inf
## Warning in max(ids, na.rm = TRUE): no non-missing arguments to max; returning
## -Inf
## Warning in max(ids, na.rm = TRUE): no non-missing arguments to max; returning
## -Inf