search

cmu-delphi / www-covidcast

Front end for interactive visualizations powering the COVIDcast website.
https://delphi.cmu.edu/covidcast/
MIT License
13 stars 2 forks source link

Fallback to latest in maps #1187

Closed sgratzl closed 2 years ago

sgratzl commented 2 years ago

addresses #1183

Prerequisites:

Summary

fallback for the overview + map to the latest available for the levels. Only relevant for the hospital admissions signal, since it has mixed signals on different levels.

image

image

image

netlify[bot] commented 2 years ago

Preview link ready!

Name Link
Latest commit 76df6820156adb5077658d5ab2326d5be2d42f24
Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/62ccdd70f7ad1f000ab53f03
Deploy Preview https://deploy-preview-1187--cmu-delphi-covidcast.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Preview link ready!

Name Link
Latest commit 43d88dcde1ff52a0de63a7ad67b469cafdcc4fa1
Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/62d89bab83cd5f0008ddb791
Deploy Preview https://deploy-preview-1187--cmu-delphi-covidcast.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ryantibs commented 2 years ago

@sgratzl --- thank you for turning this around!

I believe @duanecmu will provide the review, reading through the original issue to get a sense for what he should look out for (thank you).

I just wanted to flag some small grammar/wording issues:

duanecmu commented 2 years ago

Katie pointed out some issues that need corrected:

  1. " the indicator ..." --> " The indicator ..." (capitalization)
  2. "... available on the geographic level ..." --> "... available at the geographic level ..."
  3. "The data from ... is shown instead" --> "The data from ... is displayed instead".

Also need to fix:

  1. "the choropleth map shows no data available... -> " The chloropleth ..." (capitalization)
duanecmu commented 2 years ago

Yeah, there's a few typos that need to be fixed (see comments for details.)

On Wed, Jul 20, 2022 at 1:57 PM ryantibs @.***> wrote:

@sgratzl https://github.com/sgratzl --- thank you for turning this around!

I believe @duanecmu https://github.com/duanecmu will provide the review, reading through the original issue to get a sense for what he should look out for (thank you).

I just wanted to flag some small grammar/wording issues:

  • " the indicator ..." --> " The indicator ..." (capitalization)
  • "... available on the geographic level ..." --> "... available at the geographic level ..."
  • "The data from ... is shown instead" --> "The data from ... is displayed instead".

— Reply to this email directly, view it on GitHub https://github.com/cmu-delphi/www-covidcast/pull/1187#issuecomment-1190584352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYRVETIKZ22L3ANPMXAITG3VVA4XZANCNFSM53JN7IJA . You are receiving this because you were mentioned.Message ID: @.***>

sgratzl commented 2 years ago

  • " the indicator ..." --> " The indicator ..." (capitalization)

  • "... available on the geographic level ..." --> "... available at the geographic level ..."

  • "The data from ... is shown instead" --> "The data from ... is displayed instead".

fixed

  1. "the choropleth map shows no data available... -> " The chloropleth ..." (capitalization)

where do you see that? I cannot find this sentence

duanecmu commented 2 years ago

"the choropleth map shows no data available... -> " The chloropleth ..." (capitalization)

Where do you see that? I cannot find this sentence - My mistake, I think this was already corrected/fixed. Thanks!