cnabio / cnab-spec

Cloud Native Application Bundle Specification
https://cnab.io
Other
958 stars 99 forks source link

Add branch protections and merge restrictions #354

Closed radu-matei closed 3 years ago

radu-matei commented 4 years ago

Here is a snapshot of the current branch protections:

image

Thoughts?

vdice commented 4 years ago

we should mark the spec validation check to be required

Quick note here: validation and cnab-spec-validate are actually the same check. The former is the current name, the latter is the new name if/when the following PR is merged: https://github.com/cnabio/cnab-spec/pull/350 (So, there will ultimately only be one spec validation target. But agreed, it should remain required.)

carolynvs commented 4 years ago

Yeah we use a much more locked down set of perms on Porter's repositories because people who are not maintainers have admin rights on the organization. So this is a really good idea. 👍

Another thing we have turned on is Restrict who can push to matching branches which prevents accidental pushes directly to a branch without a pull request.

carolynvs commented 3 years ago

I have updated cnab-spec and cnab-go with our desired changes. Screen Shot 2021-01-06 at 11 52 52 AM