cncf-tags / container-device-interface

Apache License 2.0
216 stars 39 forks source link

Code cleanup #223

Closed bart0sh closed 2 months ago

bart0sh commented 3 months ago

Fixed VSCode(gopls check) warnings:

$ find . -name \*.go | xargs gopls check
cmd/cdi/cmd/cdi-api.go:287:25-39: unused parameter: spec
cmd/cdi/cmd/cdi-api.go:287:41-53: unused parameter: verbose
pkg/cdi/spec-dirs_test.go:230:20-32: unused parameter: t [windows]
pkg/cdi/spec-dirs_test.go:230:20-32: unused parameter: t
pkg/cdi/spec-dirs_test.go:189:4: ineffectual assignment to err
bart0sh commented 3 months ago

@elezar fixed CI failure. PTAL again, thanks!

bart0sh commented 2 months ago

@klihub Can you review & merge?

klihub commented 2 months ago

@klihub Can you review & merge?

Just a sec. Lemme skim through it...