fixes: enable golanci-lint in CI, fix complaints.

cncf-tags / container-device-interface

Apache License 2.0

216 stars 39 forks source link

fixes: enable golanci-lint in CI, fix complaints. #232

Closed klihub closed 1 month ago

klihub commented 1 month ago

This patch set

adds a local [golang]ci-lint Makefile target and hooks it in to pr-checks
addresses golangci-lint complaints
adds CI golangci-lint workflow

klihub commented 1 month ago

I think this looks good @klihub.

One thought is that for cases where we do record but ignore the errors, we should update the public API documentation to indiate that GetErrors() can be queried to return errors that were raised when refreshing the cache.

@elezar I updated the doc strings of the relevant Cache public API functions, with a brief mention a possible implicit cache refresh and how to obtain any errors encountered it. PTAL.