search

cncf / techdocs

CNCF TechDocs Team
https://www.cncf.io
Apache License 2.0
37 stars 26 forks source link

Revisions: Backstage doc analysis and implementation plan. #202

Closed dwelsch-esi closed 7 months ago

dwelsch-esi commented 7 months ago

Updates to README, doc analysis, and implementation plan.

dwelsch-esi commented 7 months ago

@nate-double-u This is just miscellaneous updates and edits to the original Backstage analysis. Have not yet checked in the issues list.

nate-double-u commented 7 months ago

Looking at this set of commits, this doesn't look quite right. Are the results (files changed) what you want @dwelsch-esi?

dwelsch-esi commented 7 months ago

@nate-double-u The file changes are correct. I think the way I'm working on a branch in my fork is polluting the commit history. I'm not very good with Git, I'm afraid.

nate-double-u commented 7 months ago

I think i know what happened -- because i squashed the original all the individual commits got combined. You likely didn't pull those changes down, or create a new branch from main for these changes, so you're working off your old branch (with all those original commits).

So, when a PR gets merged in, it's best practice to delete the branch that was merged. Then, if you want to make new changes, make sure your fork is up to date with main, make a new branch, make your changes, then create a new PR with the new branch.

dwelsch-esi commented 7 months ago

Closing. Will re-submit with a clean commit history.