search

coactions / setup-xvfb

Run your tests headlessly by enabling xvfb
https://github.com/marketplace/actions/setup-xvfb
MIT License
51 stars 9 forks source link

[enhancement] Do `sudo apt-get update` beforehand #15

Closed GabrielBB closed 1 year ago

GabrielBB commented 1 year ago

Please see: https://github.com/GabrielBB/xvfb-action/issues/24#issuecomment-1477672587

GabrielBB commented 1 year ago

suggestion: Could these be split into two separate async/try-catch blocks in order to report better failings to the end user?

Okay

gselzer commented 1 year ago

Hi @GabrielBB @haydncomley @ssbarnea, I'm getting bitten by this, is there anything blocking merge here?

haydncomley commented 1 year ago

Hi @GabrielBB @haydncomley @ssbarnea, I'm getting bitten by this, is there anything blocking merge here?

I've approved the changes a while ago but I'm not a maintainer so can't do much with this unfortunately..

GabrielBB commented 1 year ago

Hi @GabrielBB @haydncomley @ssbarnea, I'm getting bitten by this, is there anything blocking merge here?

@ssbarnea is code owner :/ He needs to approve/merge

ssbarnea commented 1 year ago

Thanks for mentioning me. BTW, if someone wants to help with maintenance say it and I will invite you to the repo.