search

coala / cEPs

coala Enhancement Proposals
MIT License
33 stars 53 forks source link

cEP-0005.md: Fix typo #103

Closed li-boxuan closed 6 years ago

li-boxuan commented 6 years ago

analyses --> analysis.

Fixes https://github.com/coala/cEPs/issues/102

li-boxuan commented 6 years ago

@virresh Hi, thanks! I have changed the commit message. Btw, I referred to the Example 3 which uses 'Fixes' in commit message when fixing a typo. Do you think the example should be changed? :)

virresh commented 6 years ago

Hey @li-boxuan , I just re-read the example and yes, it seems quite misleading (considering the majority of commits about fixing small typos are using Closes, including my newcomer issue :sweat_smile: ). Probably it's a good idea to discuss this in here and make an issue regarding this in the documentation repo.

li-boxuan commented 6 years ago

@virresh Sure, thanks for your advice.

Udayan12167 commented 6 years ago

Ack https://github.com/coala/cEPs/pull/103/commits/a752e387ed90fc56ed44770327978bffbfbbdbdf

jayvdb commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: