search

coala / cEPs

coala Enhancement Proposals
MIT License
33 stars 53 forks source link

Fixed typo #99

Closed kaustumbh7 closed 6 years ago

kaustumbh7 commented 6 years ago

cEP-0002.md: Correct sentence

This corrects the phrasing mistake and interchanges the words 'local' and 'global'.

Closes #98

kaustumbh7 commented 6 years ago

Ohh! Sorry my bad! ;)

newbazz commented 6 years ago

Make changes and we will have it merged by tonight ;P

kaustumbh7 commented 6 years ago

Yeah sure! :)

kaustumbh7 commented 6 years ago

Is it fine now?

Makman2 commented 6 years ago

Imperative tense please for shortlog: --> Fix typo

Also: This is not a real typo, but just a phrasing mistake. Could you maybe rephrase your commit message to resemble this?

Makman2 commented 6 years ago

unack a1d90a3

kaustumbh7 commented 6 years ago

@Makman2 Is it ok now?

ishanSrt commented 6 years ago

You are right this is not a typo. I wrote the issue incorrectly 😛. it would be better to remove the tag bug and the ask @kaustumbh7 to change the commit message accordingly. I will edit the issue cc @Makman2

kaustumbh7 commented 6 years ago

@ishanSrt Is it fine now?

ishanSrt commented 6 years ago

Use Closes instead of Fixes since this won't remain a bug or a typo 👍

kaustumbh7 commented 6 years ago

@ishanSrt Done! :)

Makman2 commented 6 years ago

ack 9f4b596

Makman2 commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: