coala / coala-atom

A coala integration plugin for Atom
https://coala.io/
GNU Affero General Public License v3.0
20 stars 23 forks source link

Add CI and clean up code #10

Closed AbdealiLoKo closed 8 years ago

AbdealiLoKo commented 8 years ago
sils commented 8 years ago

ack 3a61d41 52a8d77 27510c0 8b5672c

sils commented 8 years ago

Hey, sometimes I seem to get results for the wrong file:

screenshot from 2016-02-08 08-01-58

AbdealiLoKo commented 8 years ago

Don't merge yet

-----Original Message----- From: "Lasse Schuirmann" notifications@github.com Sent: ‎08-‎02-‎2016 12:25 To: "coala-analyzer/coala-atom" coala-atom@noreply.github.com Cc: "AbdealiJK" abdealikothari@gmail.com Subject: Re: [coala-atom] Add CI and clean up code (#10)

ack 3a61d41 52a8d77 27510c0 8b5672c — Reply to this email directly or view it on GitHub.

sils commented 8 years ago

What's missing?

AbdealiLoKo commented 8 years ago

@rultor merge

rultor commented 8 years ago

@rultor merge

@abdealijk OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 years ago

@rultor merge

@abdealijk Done! FYI, the full log is here (took me 1min)

AbdealiLoKo commented 8 years ago

That's interesting. I do not think that's a wrong result. That part of the coffee code defines a json (like defining a python dictionary). So atom finds embedded json and gives that to

-----Original Message----- From: "Lasse Schuirmann" notifications@github.com Sent: ‎08-‎02-‎2016 12:35 To: "coala-analyzer/coala-atom" coala-atom@noreply.github.com Cc: "AbdealiJK" abdealikothari@gmail.com Subject: Re: [coala-atom] Add CI and clean up code (#10)

Hey, sometimes I seem to get results for the wrong file:

— Reply to this email directly or view it on GitHub.