coala / coala-atom

A coala integration plugin for Atom
https://coala.io/
GNU Affero General Public License v3.0
20 stars 23 forks source link

Add requirements.txt #8

Closed sils closed 8 years ago

sils commented 8 years ago

we should fix the coala version for plugins

AbdealiLoKo commented 8 years ago

You mean specify installing coala 0.4.0 in the README and requirements.txt ?

On Sun, Feb 7, 2016 at 3:23 AM, Lasse Schuirmann notifications@github.com wrote:

we should fix the coala version for plugins

— Reply to this email directly or view it on GitHub https://github.com/coala-analyzer/coala-atom/issues/8.

sils commented 8 years ago

only in the requirements.txt IMO, in the readme just tell the user to do pip3 -r requirements.txt otherwise we'll forget to change it at both places

AbdealiLoKo commented 8 years ago

I'm thinking this is a bad way to do it because atom has a GUI and most users shouldn't be forced to go into ~/.atom/packages and so on.

I think the better way is to throw an error inside atom if:

On Sun, Feb 7, 2016 at 3:42 PM, Lasse Schuirmann notifications@github.com wrote:

only in the requirements.txt IMO, in the readme just tell the user to do pip3 -r requirements.txt otherwise we'll forget to change it at both places

— Reply to this email directly or view it on GitHub https://github.com/coala-analyzer/coala-atom/issues/8#issuecomment-180990940 .

AbdealiLoKo commented 8 years ago

i.e. https://github.com/coala-analyzer/coala-atom/issues/7 would be a better solution that this.

sils commented 8 years ago

ok neat