Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!
Thanks for your contribution!
Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
Fixes
keyword if the commit fixes a real bug and theCloses
keyword if it adds a feature/enhancement. See more here.As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!