search

coala / landing-frontend

coala Landing Page - https://gitlab.com/coala/landing is needed as backend
https://coala.io/
GNU Affero General Public License v3.0
32 stars 74 forks source link

snippets: Add Java #274

Closed fatma-mohamed closed 6 years ago

fatma-mohamed commented 6 years ago

Hi @IpshitaC , No I wasn't assigned. I read the Coala guide which lead me to this repo to add a code snippet and I followed the steps under "Adding new code snippets". Sorry for not following the appropriate steps. Should I request to be assigned to this issue and start from there?

IpshitaC commented 6 years ago

Yes, please ask to be assigned to this issue. Also join the org if you haven't done so already. :)

On Tue, 15 May 2018 01:38 Fatma Mohamed, notifications@github.com wrote:

Hi @IpshitaC https://github.com/IpshitaC , No I wasn't assigned. I read the Coala guide which lead me to this repo to add a code snippet and I followed the steps under "Adding new code snippets". Sorry for not following the appropriate steps. Should I request to be assigned to this issue https://github.com/coala/landing-frontend/issues/267 and start from there?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coala/landing-frontend/pull/274#issuecomment-388945722, or mute the thread https://github.com/notifications/unsubscribe-auth/ARgv8drlqWy5ctY_11MgO9VQ4B8Paqriks5tyeQ3gaJpZM4T8N3f .

palash25 commented 6 years ago

Until you are assigned @fatma-mohamed you can amend your commit message according to our guidelines and also provide a link to the corresponding issue in your PR description too.

palash25 commented 6 years ago

@fatma-mohamed why did you close this?

fatma-mohamed commented 6 years ago

I couldn't push the changes suggested on the same pull request, I accidentally deleted the repo connected to it, so I opened another one and closed this one so there won't be a duplicate.

palash25 commented 6 years ago

Alright. Whenever you get stuck with something like that try to get in touch with someone on the issue thread or on gitter.

All you need was a force push and you wouldn't have to delete the PR or your fork. I will review your PR but remember never ever delete another PR or fork ever again.

fatma-mohamed commented 6 years ago

Ok sorry and thanks for your help.

palash25 commented 6 years ago

No problem